Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chevron: filter with '*' in front #2299

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Sep 19, 2024

image

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 41m 55s ⏱️ + 5m 22s
 7 699 tests ±0   7 470 ✅  - 1  228 💤 ±0  1 ❌ +1 
24 258 runs  ±0  23 510 ✅  - 1  747 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 97b076f. ± Comparison against base commit 0986115.

♻️ This comment has been updated with latest results.

@jukzi
Copy link
Contributor Author

jukzi commented Sep 20, 2024

A second opinion about this change would be appreciated.

@BeckerWdf
Copy link
Contributor

A second opinion about this change would be appreciated.

Sure. Can you please describe the problem you want to fix? "Chevron: filter with '*' in front" is not very speaking..

@jukzi
Copy link
Contributor Author

jukzi commented Sep 20, 2024

until now the filter finds only files starting with the String:
image
and would not find others:
image
That behaviour may be OK for Open-Type Dialog which filters from thousands of classes, but there are at max 99 items to filter in the chevron and i often find that i would have liked it to find the *Test too

@jukzi
Copy link
Contributor Author

jukzi commented Sep 24, 2024

ignoring random failing PartRenderingEngineTests #751

@jukzi jukzi merged commit eb96e2e into eclipse-platform:master Sep 24, 2024
8 of 12 checks passed
@jukzi jukzi deleted the chevron_filter branch September 24, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants